Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tag): Refactor tag with the clickable div element #145

Merged
merged 3 commits into from
Aug 26, 2021
Merged

refactor(tag): Refactor tag with the clickable div element #145

merged 3 commits into from
Aug 26, 2021

Conversation

mfarukkoc
Copy link
Contributor

Description

To fix the bug with Typeahead usage in FormField component:

  • Tag component is refactored with the clickable div element.

Closes #132

@mfarukkoc mfarukkoc self-assigned this Aug 10, 2021
yasincaliskan
yasincaliskan reviewed Aug 16, 2021
View reviewed changes
mucahit
mucahit approved these changes Aug 19, 2021
View reviewed changes
@edizcelik edizcelik added Ready for new release PR is reviewed and ready to be merged and removed ready for review labels Aug 26, 2021
@mucahit mucahit merged commit ff0f210 into next-release Aug 26, 2021
@mucahit mucahit deleted the fix/typeahead-formfield-bug branch August 26, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasincaliskan yasincaliskan yasincaliskan left review comments

@mucahit mucahit mucahit approved these changes

@edizcelik edizcelik edizcelik approved these changes

@jamcry jamcry Awaiting requested review from jamcry

@bilgeyucel bilgeyucel Awaiting requested review from bilgeyucel

@Anlerkan Anlerkan Awaiting requested review from Anlerkan

Assignees

@mfarukkoc mfarukkoc

Labels
Ready for new release PR is reviewed and ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mfarukkoc @mucahit @edizcelik @yasincaliskan