Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(toggle): Refactor toggle with input element #146

Merged
merged 2 commits into from
Aug 26, 2021

Conversation

mfarukkoc
Copy link
Contributor

Description

Refactored Toggle component with input element,

  • If the toggle is multi-select, use checkbox input
  • If the toggle is single select, use radio input

Note: I am unable to use RadioInput and CheckboxInput components because they require the item prop and using icons.

Closes #144

* Use checkbox input if toggle is multi select
* Use radio input if toggle is single select
@mucahit mucahit added Ready for new release PR is reviewed and ready to be merged and removed ready for review labels Aug 19, 2021
@mucahit mucahit merged commit f916ef5 into next-release Aug 26, 2021
@mucahit mucahit deleted the feat/use-input-on-toggle branch August 26, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for new release PR is reviewed and ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants