Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(progress-bar): Update ProgressBar component props #150

Merged
merged 2 commits into from
Sep 16, 2021
Merged

fix(progress-bar): Update ProgressBar component props #150

merged 2 commits into from
Sep 16, 2021

Conversation

yigiterdev
Copy link
Contributor

@yigiterdev yigiterdev commented Aug 24, 2021 •
edited
Loading

Description

  • ProgressBar expects Component style as prop. It is already defined as default below. It should be optional
  • Made style prop optional

@yigiterdev yigiterdev self-assigned this Aug 24, 2021
edizcelik
edizcelik suggested changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@edizcelik edizcelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails when we pass style as {trackcolor: "#333333"}. This would make backgroundColor and the values for other properties within style undefined.

@edizcelik
Copy link
Contributor

This is a public repo. Instead of giving a link to a private Slack conversation, we should explain the issue here in the PR description.

@yigiterdev yigiterdev requested a review from edizcelik August 26, 2021 09:32
@mucahit mucahit merged commit 7ba99e6 into next-release Sep 16, 2021
@mucahit mucahit deleted the fix/progress-bar-style-prop branch September 16, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mucahit mucahit mucahit approved these changes

@jamcry jamcry Awaiting requested review from jamcry

@bilgeyucel bilgeyucel Awaiting requested review from bilgeyucel

@Anlerkan Anlerkan Awaiting requested review from Anlerkan

@yasincaliskan yasincaliskan Awaiting requested review from yasincaliskan

@edizcelik edizcelik Awaiting requested review from edizcelik

Assignees

@yigiterdev yigiterdev

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yigiterdev @edizcelik @mucahit