fix(number-input): Turn off formatting for Android and iOS devices #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasincaliskan
requested review from
mucahit,
edizcelik,
jamcry,
Anlerkan,
ErenYLCN,
akgunberk,
tatata96,
yigiterdev and
gulcinuras
|
I talked with Kaan about this and he said if we are cancelling localization for Android devices, we should probably cancel it on iOS as well. So, I think we can also remove localization from iOS. So, the localization of the NumberInput will only be allowed for desktops. |
edizcelik
suggested changes
Oct 25, 2021
yasincaliskan
changed the title
edizcelik
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Input(A.K.ANumberInput) had weird behavior on some Android devices. When we try to write1000, the value was becoming1.0001000. This issue is the same with1001,1008, etc.Intl.FormatNumberbut we haven't found any sensible reason. And we decided to exclude formatting for Android and iOS devices.isMobileDeviceutility was added. That's way, all Android and iOS devices can only have scientific notation with theen-USlocale.