Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(date-timer): Refactor Countdown as DateTimer #178

Merged
merged 2 commits into from
Feb 21, 2022

Conversation

mucahit
Copy link
Contributor

@mucahit mucahit commented Jan 13, 2022

Details

Countdown component has been repurposed as DateTimer, now it gets range: Date[] prop and countdowns to the greater date from the origin date.

The other use case is Countup functionality, if you pass timerType="up", DateTimer will expect a date greater than today so that it can count up to that date.

  • range prop could be unordered, it will be handled by calculateRemainingTimeBreakdown
    • If there are more than 1 dates passed in the range prop, calculateRemainingTimeBreakdown will assign the greater date to targetDate

This is a Breaking change

@mucahit mucahit merged commit f50cd3d into next-release Feb 21, 2022
@mucahit mucahit deleted the feat/refactor-countdown-as-date-timer branch February 21, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants