fix(numberInput):Cursor Positioning Fixed #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamcry
reviewed
Jan 26, 2022
src/form/input/Input.tsx
Outdated
| if ( | ||
| prevValueThousandthsSeparatorCount === | ||
| thousandthsSeparatorCount + 1 | ||
| // eslint-disable-next-line no-magic-numbers |
There was a problem hiding this comment.
Suggested change
| // eslint-disable-next-line no-magic-numbers |
Do we need this? It shouldn't give magic-numbers error for 1
edizcelik
reviewed
Jan 26, 2022
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@hipo/react-ui-toolkit", | |||
| "version": "1.0.0-alpha.5.1.0", | |||
| "version": "1.0.0-alpha.5.1.1", | |||
There was a problem hiding this comment.
Version change shouldn't have been done here. It is generally better if the person who is preparing the new published version to update the version of the package after all the changes are merged. Also version changes should be reflected on the package-lock file as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When user tries to enter a new input by selecting the default value and typing the new input without deleting the current one, the cursor appears on the left side of the new input when it should be on the right side, there is no issue when the default value is deleted and the new input is entered afterwards. You can test it in "Number Input with shouldFormatToLocaleString".
Solution:
A condition added to distinguish if one digit is edited, if so cursor positioning is applied, if not meaning that the input is a new one cursor position not modified.