-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(number-input): Separation of NumberInput
and Input
#200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Yasin 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Yasin, I think this is good to go 🚀
Though, I believe it'd be nice to get this tested on mobile and old unsupported browsers before including it in the next release. (To make sure our checks are working and nothing is broken on those browsers)
Maybe we can push this branch to somewhere (netlify/github pages) and request QA to somehow test this, or we can test it ourselves using our devices and CrossBrowserTesting app
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good news: now we have PR preview links
Bad news: Unsupported browsers still cause problems 😅
I briefly tried to debug this. Although we don't directly use getNumberSeparators
function, some other utils use it internally. (For example parseNumber
). And we use it inside some number input utils, which are called for all type of devices. I think that's the problem.
I love the PR review! Thanks Cem 🎉 |
Description
NumberInput
component and moved the related props, utilities, tests fromInput
toNumberInput
.localizeNumberInputValue
anddelocalizeNumberInputValue
in order to clean up the component body and change handler.