Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(number-input): Add NumberInput Component #71

Merged
merged 9 commits into from
Apr 21, 2021
Merged

feat(number-input): Add NumberInput Component #71

merged 9 commits into from
Apr 21, 2021

Conversation

yasincaliskan
Copy link
Contributor

@yasincaliskan yasincaliskan commented Apr 12, 2021 •
edited
Loading

Description

  • NumberInput component has added.
  • Add Number utilities have added.
  • Core utilities have grouped.
  • shouldFormatToLocaleString has removed.

Related Issue

@yasincaliskan yasincaliskan added the W.I.P Work in progress label Apr 12, 2021
@yasincaliskan yasincaliskan self-assigned this Apr 12, 2021
@yasincaliskan yasincaliskan added ready for review and removed W.I.P Work in progress labels Apr 13, 2021
@yasincaliskan yasincaliskan marked this pull request as ready for review April 13, 2021 11:22
mucahit
mucahit suggested changes Apr 14, 2021
View reviewed changes
@yasincaliskan yasincaliskan requested a review from mucahit April 14, 2021 10:54
edizcelik
edizcelik suggested changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@edizcelik edizcelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we agree that this NumberInput will be an abstraction of Input component when the type is provided as "number" ? Meaning Input component will use NumberInput behind the scenes if type === "number"

edizcelik
edizcelik suggested changes Apr 15, 2021
View reviewed changes
bilgeyucel
bilgeyucel approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@bilgeyucel bilgeyucel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@yasincaliskan yasincaliskan requested a review from edizcelik April 16, 2021 10:56
edizcelik
edizcelik reviewed Apr 16, 2021
View reviewed changes
@yasincaliskan yasincaliskan requested a review from edizcelik April 16, 2021 14:35
@edizcelik edizcelik added the Ready for new release PR is reviewed and ready to be merged label Apr 20, 2021
@yasincaliskan yasincaliskan merged commit 217dc9d into master Apr 21, 2021
@yasincaliskan yasincaliskan deleted the feat/number-input branch May 7, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mucahit mucahit mucahit approved these changes

@edizcelik edizcelik edizcelik approved these changes

@jamcry jamcry jamcry approved these changes

@bilgeyucel bilgeyucel bilgeyucel approved these changes

@Anlerkan Anlerkan Anlerkan approved these changes

Assignees

@yasincaliskan yasincaliskan

Labels
Ready for new release PR is reviewed and ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yasincaliskan @mucahit @edizcelik @jamcry @bilgeyucel @Anlerkan