Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(spinner): Simplify Spinner Component #81

Merged
merged 5 commits into from
Apr 29, 2021
Merged

refactor(spinner): Simplify Spinner Component #81

merged 5 commits into from
Apr 29, 2021

Conversation

yasincaliskan
Copy link
Contributor

Note

  • Spinner takes just color as a prop.

Related Issue

@yasincaliskan yasincaliskan self-assigned this Apr 20, 2021
mucahit
mucahit reviewed Apr 20, 2021
View reviewed changes
@yasincaliskan yasincaliskan requested a review from mucahit April 20, 2021 16:33
edizcelik
edizcelik reviewed Apr 26, 2021
View reviewed changes
@yasincaliskan yasincaliskan requested a review from edizcelik April 26, 2021 09:49
@yasincaliskan yasincaliskan mentioned this pull request Apr 26, 2021
Merged
mucahit
mucahit approved these changes Apr 27, 2021
View reviewed changes
bilgeyucel
bilgeyucel approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@bilgeyucel bilgeyucel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@edizcelik edizcelik added Ready for new release PR is reviewed and ready to be merged and removed ready for review labels Apr 28, 2021
@yasincaliskan yasincaliskan merged commit 011aa68 into master Apr 29, 2021
@yasincaliskan yasincaliskan deleted the refactor/spinner branch May 7, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mucahit mucahit mucahit approved these changes

@edizcelik edizcelik edizcelik approved these changes

@jamcry jamcry jamcry approved these changes

@bilgeyucel bilgeyucel bilgeyucel approved these changes

@Anlerkan Anlerkan Anlerkan approved these changes

Assignees

@yasincaliskan yasincaliskan

Labels
Ready for new release PR is reviewed and ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yasincaliskan @mucahit @edizcelik @jamcry @bilgeyucel @Anlerkan