Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(button): Adjust dynamically button width #84

Merged
merged 8 commits into from
May 4, 2021
Merged

feat(button): Adjust dynamically button width #84

merged 8 commits into from
May 4, 2021

Conversation

yasincaliskan
Copy link
Contributor

@yasincaliskan yasincaliskan self-assigned this Apr 22, 2021
edizcelik
edizcelik reviewed Apr 22, 2021
View reviewed changes
@yasincaliskan yasincaliskan requested a review from edizcelik April 23, 2021 10:52
jamcry
jamcry reviewed Apr 26, 2021
View reviewed changes
@yasincaliskan yasincaliskan requested a review from jamcry April 26, 2021 10:19
@yasincaliskan yasincaliskan requested a review from mucahit April 27, 2021 08:30
bilgeyucel
bilgeyucel approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@bilgeyucel bilgeyucel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the ongoing discussion, looks nice 👍

jamcry
jamcry reviewed Apr 28, 2021
View reviewed changes
@yasincaliskan yasincaliskan requested a review from jamcry April 28, 2021 15:44
mucahit
mucahit approved these changes May 3, 2021
View reviewed changes
src/button/_button.scss
@@ -31,6 +33,14 @@
cursor: not-allowed;
}

.button__spinner-container {
position: absolute;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure but probably we need to set top,left,right,bottom to 0 make sure it's on correct position

@yasincaliskan yasincaliskan added Ready for new release PR is reviewed and ready to be merged and removed ready for review labels May 3, 2021
@yasincaliskan yasincaliskan changed the base branch from master to next-release May 4, 2021 13:07
@yasincaliskan yasincaliskan merged commit 63564c4 into next-release May 4, 2021
@yasincaliskan yasincaliskan deleted the fix/dynamically-button-width branch May 4, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mucahit mucahit mucahit approved these changes

@edizcelik edizcelik edizcelik approved these changes

@jamcry jamcry jamcry approved these changes

@bilgeyucel bilgeyucel bilgeyucel approved these changes

@Anlerkan Anlerkan Anlerkan approved these changes

Assignees

@yasincaliskan yasincaliskan

Labels
Ready for new release PR is reviewed and ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yasincaliskan @mucahit @edizcelik @jamcry @bilgeyucel @Anlerkan