Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Always require file extension for imports #22

Merged
merged 2 commits into from
Oct 7, 2021

Conversation

titouanmathis
Copy link
Contributor

As the JS ecosystem grows towards modules, using file extensions for imports is becoming the norm (see Node.js modules and vitejs/vite#178 (comment) for Vue).

This PR updates the ESLint rule import/extension to always require file extension.

This is a breaking change.

@titouanmathis titouanmathis requested review from a team April 12, 2021 16:12
@titouanmathis titouanmathis self-assigned this Apr 12, 2021
@titouanmathis titouanmathis force-pushed the feature/always-require-file-extension branch from 583c88c to 23dd94b Compare April 12, 2021 16:13
@perruche
Copy link
Contributor

👍

@titouanmathis titouanmathis merged commit 7930f06 into develop Oct 7, 2021
@titouanmathis titouanmathis deleted the feature/always-require-file-extension branch January 4, 2022 17:32
titouanmathis added a commit that referenced this pull request Jan 4, 2022
v3.0.0-beta.0

Added
- Add best practices rules from [eslint-plugin-unicorn](https://github.com/sindresorhus/eslint-plugin-unicorn) (#33)
- Add JS Doc rules from [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) (#33)
- Add [@rushstack/eslint-patch](https://github.com/microsoft/rushstack/blob/master/eslint/eslint-patch/README.md) to fix plugin issues (#33)

Changed
- **Breaking:** Always require file extension for imports (#22)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants