Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by cost fix #37

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Filter by cost fix #37

wants to merge 3 commits into from

Conversation

frank-cywong
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Apr 19, 2023

Deploy Preview for opportunities ready!

Name Link
🔨 Latest commit 0516344
🔍 Latest deploy log https://app.netlify.com/sites/opportunities/deploys/6440212513d6bc000892996f
😎 Deploy Preview https://deploy-preview-37--opportunities.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@frank-cywong
Copy link
Member Author

While it doesn't query every time now, it still seems to rerender the entire thing, so it's still very slow and doesn't really work

@frank-cywong frank-cywong marked this pull request as draft April 19, 2023 17:13
Copy link
Member

@TheEgghead27 TheEgghead27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great way to cut down on rerenders! Does make the number input a little sluggish but it's fair.

(unrelated bug - just realized the scrolling for filters on mobile requires you to scroll to the bottom of the whole catalog, then you can get to cost filter)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants