Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added spacing below the sponsors text #1020

Merged
merged 1 commit into from
Nov 11, 2023
Merged

fix: added spacing below the sponsors text #1020

merged 1 commit into from
Nov 11, 2023

Conversation

MathurAditya724
Copy link
Contributor

Resolved Issue #1016

  • added some margin above each sponsor component to make them evenly spaced

@vercel Vercel
Copy link

vercel bot commented Nov 5, 2023

@MathurAditya724 is attempting to deploy a commit to the Package Phobia Team on Vercel.

A member of the Team first needs to authorize it.

styfle
styfle reviewed Nov 6, 2023
View reviewed changes
Copy link
Owner

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the git diff so big for adding margin?

@MathurAditya724
Copy link
Contributor Author

Changes -

  • Added sponsors in an array, in place of hard coding them in a single component.
  • Added a loop to render them
  • Set the height to auto, as Vercel and Upstash logo have different heights
  • Added margin-top property for the spacing (5px)
  • Removed the fragements, as it was not getting used.

The diff is quite big cause I shifted the svg logo from the component into an array. I haven't changed the svg's.

@vercel Vercel
Copy link

vercel bot commented Nov 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
packagephobia ✅ Ready (Inspect) Visit Preview Nov 11, 2023 8:43pm

@styfle styfle linked an issue Nov 11, 2023 that may be closed by this pull request
Add some spacing between sponsors #1016
Closed
1 task
styfle
styfle approved these changes Nov 11, 2023
View reviewed changes
Copy link
Owner

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@styfle styfle merged commit 1d548f5 into styfle:main Nov 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add some spacing between sponsors
2 participants
@MathurAditya724 @styfle