Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: switch from yarn@3 to npm@10 #1021

Merged
merged 9 commits into from
Nov 12, 2023
Merged

feat!: switch from yarn@3 to npm@10 #1021

merged 9 commits into from
Nov 12, 2023

Conversation

styfle
Copy link
Owner

@styfle styfle commented Nov 12, 2023 •
edited
Loading

  • Switch from yarn@3 to npm@10
  • Upgrade from node@16 to node@18

This also fixes a bug with measuring sharp as seen here:

@vercel Vercel
Copy link

vercel bot commented Nov 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
packagephobia ✅ Ready (Inspect) Visit Preview Nov 12, 2023 3:04am

@socket-security Socket Security
Copy link

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
npm 10.2.3 network, filesystem, shell, environment +1 20.9 MB lukekarrys
@types/semver 7.5.5...7.5.4 None +0/-0 23.2 kB types
@types/react-dom 18.2.15...18.2.14 None +1/-1 396 kB types
@types/react 18.2.37...18.2.36 None +0/-0 363 kB types
@types/node 18.18.9...18.18.8 None +0/-0 3.8 MB types

🚮 Removed packages: [email protected]

@styfle styfle marked this pull request as ready for review November 12, 2023 03:06
@styfle styfle merged commit 80f74e3 into main Nov 12, 2023
6 checks passed
@styfle styfle deleted the npm-10 branch November 12, 2023 03:10
This was referenced Nov 12, 2023
Closed
Closed
@styfle styfle mentioned this pull request Dec 1, 2023
Merged
styfle added a commit that referenced this pull request Dec 1, 2023
@styfle
fix: omit peer dependencies (#1028)
c758185 
Back when Package Phobia first came out in 2018, it used `npm@5` to
install dependencies and measure the size. That was later upgrade to
[npm@6](#164) with little
behavior changed.

Then upgrading node caused problems with the old version of npm so
Package Phobia switched to
[yarn@2](#959) and later
[yarn@3](#976) which both
omit peer dependencies by default.

Recently, Package Phobia switched to
[npm@10](#1021) which will
automatically install peer dependencies.

This PR will change the behavior back to omit peer dependencies.

- Fixes #1025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question: is yarn size fair comparison with npm?
1 participant
@styfle