Fix section pages if section name has inappropriate symbols #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have a forward slash in your section name, the pagePerSection links are all broken, resulting in "Page not found". Removing the forward slashes in the names fixes the issue. For example: pagePerSection links break when section name includes a "/", like `name: '@foo/components'` Solution is just encode name in the getUrl and then correctly decode it in the router logic. iss: styleguidist#1332
Codecov Report
|
|
Thanks! |
|
🎉 This PR is included in version 9.1.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a forward slash in your section name, the pagePerSection links are all broken,
resulting in "Page not found".
For example:
pagePerSection links break when section name includes a "/", like
name: '@foo/components'The solution is just to encode a name in the getUrl and then correctly
decode it in the router hash logic.
iss: #1332