Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1375 - Highlighting currently selected page on sidebar broken with sections #1405

Merged
merged 2 commits into from
Jul 26, 2019

Conversation

jkarttunen
Copy link

Fix with IF condition. Check if routing is based on flat or sectioned system.

@codecov-io
Copy link

codecov-io commented Jul 24, 2019

Codecov Report

Merging #1405 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted Files Coverage Δ
...omponents/ComponentsList/ComponentsListRenderer.js 100% <100%> (ø) ⬆️
src/client/utils/handleHash.js 92.3% <0%> (-3.85%) ⬇️
src/client/rsg-components/slots/IsolateButton.js 100% <0%> (ø) ⬆️
src/scripts/make-webpack-config.js 100% <0%> (ø) ⬆️

Copy link
Member

@sapegin sapegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Couple of minor comments.

@jkarttunen jkarttunen changed the title Fix #1375 Fix #1375 - Highlighting currently selected page on sidebar broken with sections Jul 26, 2019
@sapegin sapegin merged commit d1e528f into styleguidist:master Jul 26, 2019
@sapegin
Copy link
Member

sapegin commented Jul 26, 2019

Merging, thanks! 🌮

@styleguidist-bot
Copy link
Collaborator

🎉 This PR is included in version 9.1.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants