refactor: introduce Table components for use in Markdown #613 #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
sapegin
requested changes
Feb 26, 2018
| thead: { | ||
| composes: '$hr', | ||
| }, | ||
| tbody: {}, |
There was a problem hiding this comment.
Should we create TableBody and TableRow component to make styling possible?
|
|
||
| export function TableCellRenderer({ classes, header, children }) { | ||
| if (header) { | ||
| return <th className={cx(classes.td, classes.th)}>{children}</th>; |
There was a problem hiding this comment.
We can use JSS composition (like in the original version: composes: '$td') and avoid classnames, I this it would be a little bit nicer ;-)
|
|
||
| const styles = ({ space, color, fontFamily }) => ({ | ||
| table: { | ||
| ...paraStyles({ space, color, fontFamily }).para, |
There was a problem hiding this comment.
I think we should define color and line-height on td, and then we only need margin from Para which whould be copied here.
|
Thanks, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier for consumers to override individual components in their styleguide, specifically tables in this PR.