Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Jest configs by default #205

Closed
ybiquitous opened this issue Jan 30, 2023 · 1 comment · Fixed by #211
Closed

Exclude Jest configs by default #205

ybiquitous opened this issue Jan 30, 2023 · 1 comment · Fixed by #211
Labels
status: ask to implement ask before implementing as may no longer be relevant

Comments

@ybiquitous
Copy link
Member

What is the problem you're trying to solve?

Like stylelint/create-stylelint#1, when we'd like to use Vitest instead of Jest, including the following Jest configs by default is not helpful because a Jest rule requires installing the Jest package:

"plugin:jest/recommended",
"plugin:jest/style",

See https://github.com/stylelint/stylelint-create/pull/1/files#r1088492886

What solution would you like to see?

I suggest adding one more config for Jest:

Default:

{
  "extends": ["stylelint"]
}

For Jest:

{
  "extends": ["stylelint/jest"]
}

This change should be a major release because of a breaking change.

@ybiquitous ybiquitous added the status: needs discussion triage needs further discussion label Jan 30, 2023
@jeddy3 jeddy3 added type: enhancement status: ask to implement ask before implementing as may no longer be relevant and removed status: needs discussion triage needs further discussion labels Jan 31, 2023
@jeddy3
Copy link
Member

jeddy3 commented Jan 31, 2023

SGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ask to implement ask before implementing as may no longer be relevant
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants