-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minimum working example #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this MVP. It seems great as a basis!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, added some comments...
Co-authored-by: Masafumi Koba <[email protected]>
Co-authored-by: Masafumi Koba <[email protected]>
Co-authored-by: Masafumi Koba <[email protected]>
This reverts commit 4ce832c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
I've made some suggestions.
I don't think we're far off having this ready. It'd be nice to roll it into the v15 launch.
Thanks everyone for chiming in - will get to addressing reviews soon! Just to be transparent, won't be able to work on this likely until Friday or the weekend (catching up after travelling for interviews)! |
Co-authored-by: Richard Hallows <[email protected]>
Co-authored-by: Masafumi Koba <[email protected]> Co-authored-by: Marc G. <[email protected]>
7874582
to
0741651
Compare
…otations in main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left one question, but SGTM. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great!
I've added a minor suggestion.
Co-authored-by: Richard Hallows <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! LGTM 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff. I think we can merge this MVP and then pick up any improvements in new tickets and PRs.
This PR is a minimum working example (or MVP) for
stylelint-create
. Functionally, it has a simple workflow:package.json
existsstylelint
andstylelint-config-standard
with the package manager's installerIn addition, I've:
I've been manually testing with
node create-stylelint.mjs
in the project root, though I'm sure that there are better ways to do this.I do have a few things I'd like some opinions/help on!
Questions
High-level:
Specific:
Items Left
Let me know if we think any of these are unnecessary, or if I am missing something.
package.json
doesn't existexeca
for this)I'd love to keep working on this and add other features soon!
Ref: stylelint/stylelint#4269.