Add Faker::Auto features to Faker::Vehicle #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # lib/faker.rb # lib/faker/phone_number.rb # lib/locales/en-CA.yml # lib/locales/en.yml
… hash. Fixed by creating a key that contains a random make.
vbrazo
reviewed
May 31, 2018
test/test_faker_vehicle.rb
Outdated
| def test_year | ||
| year = @tester.year | ||
| assert year >= 1981 | ||
| assert year <= ::Time.now.year |
There was a problem hiding this comment.
1981 works but I think we should use 2005 instead. What do you think?
There was a problem hiding this comment.
Yeah, that sounds much better. Considering the range for the year method starts with 2005 😅
Closed
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* add automotive data * allow for area and subscriber codes in canadian phone numbers * numberize phone number parts * improve auto data to always have correct makes and models pairs * fix Faker::Auto specs * fix Faker::Auto.model when called without make * use rand_in_range method * Added locales file for Auto data. * Fixed issues in the Auto.model due to fetch not being able to fetch a hash. Fixed by creating a key that contains a random make. * Moved Faker::Auto features into Faker::Vehicle. * Updated documentation for Faker::Vehicle. * Added missing tests. * Fixed Rubocop offences. * Updated the assertion so it matches the minimum range that the year method uses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in reference to PR #692.
Some tests were missing from the original work, so I have added those in 👍