Corrected other occurrences of spelling vehicle spelling error, deprecated Space launch_vehicule #1634
Conversation
Siyanda
commented
Jun 17, 2019
Siyanda
commented
- bundle exec rubocop
- Deprecated launch_vehicule before removing it.
| extend Gem::Deprecate | ||
|
|
||
| def launch_vehicule | ||
| Faker::Space.launch_vehicule |
There was a problem hiding this comment.
it should be Faker::Space.launch_vehicle, otherwise it will crash
| Faker::Space.launch_vehicule | ||
| end | ||
|
|
||
| deprecate :launch_vehicule, 'Faker::Space.launch_vehicule', 2019, 06 |
There was a problem hiding this comment.
It should be
deprecate :launch_vehicule, 'Faker::Space.launch_vehicle', 2019, 06
| end | ||
|
|
||
| def launch_vehicule | ||
| assert @tester.character.match(/\w+/) |
There was a problem hiding this comment.
copy and 🍝
it should be @tester.launch_vehicule.match :)
There was a problem hiding this comment.
You got me there, It's my first time deprecating a method, so I searched for a similar commit and copy paste
|
In this case, you don't need to create a new file because I'd suggest deprecating the method inside the same faker object. You'd end up having a |
vbrazo
force-pushed
the
master
branch
3 times, most recently
from
69291b2 to
5cc660c
Compare
…cated Space launch_vehicule (faker-ruby#1634) * deperecated misspelled launch_vehicule and removed test * corrected other occurrences of spelling vehicle spelling error and added to tests * deprecation and tests for Space.launch_vehicle * Remove unnecessary test
…cated Space launch_vehicule (faker-ruby#1634) * deperecated misspelled launch_vehicule and removed test * corrected other occurrences of spelling vehicle spelling error and added to tests * deprecation and tests for Space.launch_vehicle * Remove unnecessary test
