Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected other occurrences of spelling vehicle spelling error #1623

Closed
wants to merge 2 commits into from
Closed

Corrected other occurrences of spelling vehicle spelling error #1623

wants to merge 2 commits into from

Conversation

Siyanda
Copy link
Contributor

@Siyanda Siyanda commented Jun 8, 2019

Found a few other places that needed correcting

vbrazo
vbrazo requested changes Jun 14, 2019
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to deprecate launch_vehicule before removing it.

Please follow the instructions (number 8) in our contributing.

Thanks.

@Siyanda
Copy link
Contributor Author

Siyanda commented Jun 17, 2019

Thanks, I have followed the instructions and corrected accordingly, also created a draft pr to be reviewed

@vbrazo vbrazo closed this Jun 17, 2019
@vbrazo
Copy link
Member

vbrazo commented Jun 17, 2019

Closing this PR since we're going to work with the draft one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo vbrazo requested changes

Assignees

@Siyanda Siyanda

Labels
🐞 Issue: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Siyanda @vbrazo