Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added myself #368

Merged
merged 3 commits into from
Oct 20, 2020
Merged

Added myself #368

merged 3 commits into from
Oct 20, 2020

Conversation

mohsin-code
Copy link
Contributor

@mohsin-code mohsin-code commented Oct 20, 2020

Issue

#260
#259

Description

Add myself to readme and to contributors.js

Checklist

  • Added contributor object in ascending order in contributors.json
  • Github action build passing
  • No merge conflicts

@github-actions
Copy link

Thanks for contributing to developer-community-stats!
We are happy to have you as a contributor. Your PR will be reviewed and merged to master.
Once it is merged you can see your stats in: https://developer-community-stats.netlify.app/

If you want to contribute to other issues check out Issues needed Help

Please share your feedback and suggestions in this Issue: Suggestions
This will help us improve a lot :)
Note: Don't forget to star, share the repository and follow @subeshb1 :)

@subeshb1
Copy link
Owner

There are conflicts

Copy link
Owner

@subeshb1 subeshb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix syntax and order in ascending alphabetically

@mohsin-code
Copy link
Contributor Author

Changes done! Please merge. Thank you.

@mohsin-code mohsin-code requested a review from subeshb1 October 20, 2020 03:01
@subeshb1
Copy link
Owner

Hi @mohsin-code. When you have done everything described in the issue and meet every checklist. The PR will be merge. Not a good practice to request the merging of PRs

@subeshb1 subeshb1 merged commit 559e734 into subeshb1:main Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants