[Scala] Tweak string and interpolation scopes #4132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit tweaks string and interpolation related scopes after the scheme
of Python and ShellScript.
1. from python use `meta.string.interpolated` and `string.quoted.double.block`
2. from shell use interpolation scopes.
Scope guidelines request `punctuation.section.interpolation.[begin|end]`,
but `$` variables are historically scoped `punctuation.definition.variable`.
This commit (as shellscript) attempt to satisfy both.
Hence `$` in `${}` is scoped punctuation.definition.variable, which may
appear odd in the first place.
Actually `$` is some sort of expansion operator, which adds a variable's
or expression's result into containing string. Perl calls it dereferencing
operator.
Most core syntaxes supporting that kind of syntax struggle with it,
currently.
TL;TR This commit aligns scopes with existing core syntaxes even though
there are still some caveats.
djspiewak
suggested changes
Jan 7, 2025
|
Reverted triple-quoted scope to |
djspiewak
approved these changes
Jan 7, 2025
michaelblyons
approved these changes
Jan 7, 2025
jrappen
reviewed
Jan 7, 2025
jrappen
reviewed
Jan 7, 2025
jrappen
reviewed
Jan 7, 2025
jrappen
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit tweaks string and interpolation related scopes after the scheme of Python and ShellScript.
from python use
meta.string.interpolatedandstring.quoted.double.blockfrom shell use interpolation scopes.
Scope guidelines request
punctuation.section.interpolation.[begin|end], but$variables are historically scopedpunctuation.definition.variable.This commit (as shellscript) attempt to satisfy both.
Hence
$in${}is scoped punctuation.definition.variable, which may appear odd in the first place.Actually
$is some sort of expansion operator, which adds a variable's or expression's result into containing string. Perl calls it dereferencing operator.Most core syntaxes supporting that kind of syntax struggle with it, currently.
TL;TR This commit aligns scopes with existing core syntaxes even though there are still some caveats. Solving them is however a bigger task affecting various syntaxes. Good consistent alternatives are required first.