-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ST3 does not correctly highlight hyphenated elements in Ruby HAML #119
Comments
Call me crazy, but there are tags with hypen? Can you name some?
On Sunday, 4 August 2013 at 21:02, Niall Smart wrote:
|
Maybe when you are using HAML for generating custom XML, but I don't think this would be appropriate in an embedded HAML highlighter (Ruby), only for standalone HAML. |
It's quite common when using AngularJS. Hyphens are used in many built-in directives and in custom directives by convention. For an example see ng-include. |
Ah! So for attributes! |
Well those too, but this bug is for element names :) |
Like this: <ng-include src="file.html"/> |
+1 this should be merged.. it's kinda bugging me too when writing angularJS app using haml :) |
Hey guys, just wanted to voice my support in having this merged! I'm also using angular in haml at the moment, and the issue appears. |
This issue was moved to jskinner/DefaultPackages#60 |
ST3's Ruby HAML highlighter does not correctly highlight tag names containing hyphens – it stops at the first hyphen. For example, in the fragment below, it just highlights
%foo
This patch fixes the issue:
https://gist.github.com/niallsmart/6151200
The text was updated successfully, but these errors were encountered: