Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ST3 does not correctly highlight hyphenated elements in Ruby HAML #119

Closed
niallsmart opened this issue Aug 4, 2013 · 9 comments
Closed

Comments

@niallsmart
Copy link

ST3's Ruby HAML highlighter does not correctly highlight tag names containing hyphens – it stops at the first hyphen. For example, in the fragment below, it just highlights %foo

%foo-bar(class="baz")

This patch fixes the issue:

https://gist.github.com/niallsmart/6151200

@iamntz
Copy link
Contributor

iamntz commented Aug 4, 2013

Call me crazy, but there are tags with hypen? Can you name some?

  • Ionut

On Sunday, 4 August 2013 at 21:02, Niall Smart wrote:

ST3's Ruby HAML highlighter does not correctly highlight tag names containing hyphens – it stops at the first hyphen. For example, in the fragment below, it just highlights %foo
%foo-bar(class="baz")

This patch fixes the issue:
https://gist.github.com/niallsmart/6151200


Reply to this email directly or view it on GitHub (#119).

@FichteFoll
Copy link
Collaborator

Maybe when you are using HAML for generating custom XML, but I don't think this would be appropriate in an embedded HAML highlighter (Ruby), only for standalone HAML.

@niallsmart
Copy link
Author

It's quite common when using AngularJS. Hyphens are used in many built-in directives and in custom directives by convention. For an example see ng-include.

@iamntz
Copy link
Contributor

iamntz commented Aug 5, 2013

Ah! So for attributes!
(i used haml only once, like ages ago)
Thanks.

@niallsmart
Copy link
Author

Well those too, but this bug is for element names :)

@niallsmart
Copy link
Author

Like this: <ng-include src="file.html"/>

@giosakti
Copy link

+1 this should be merged.. it's kinda bugging me too when writing angularJS app using haml :)

@dillonforrest
Copy link

Hey guys, just wanted to voice my support in having this merged! I'm also using angular in haml at the moment, and the issue appears.

@titoBouzout
Copy link
Collaborator

This issue was moved to jskinner/DefaultPackages#60

@sublimehq sublimehq locked and limited conversation to collaborators Dec 22, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants