Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minimum scale required for decimal literal #117

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

scgkiran
Copy link
Contributor

@scgkiran scgkiran commented Feb 6, 2025

Report line number in testcase parser

Report line number in testcase parser
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 36.50794% with 40 lines in your changes missing coverage. Please review.

Project coverage is 63.76%. Comparing base (e1e6157) to head (43c9a37).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
testcases/parser/visitor.go 28.88% 32 Missing ⚠️
types/parser/util/error_listener.go 33.33% 4 Missing ⚠️
types/parser/visitor.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   63.60%   63.76%   +0.15%     
==========================================
  Files          44       44              
  Lines       10873    10875       +2     
==========================================
+ Hits         6916     6934      +18     
+ Misses       3639     3630       -9     
+ Partials      318      311       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EpsilonPrime EpsilonPrime merged commit 00a91c9 into substrait-io:main Feb 7, 2025
7 of 8 checks passed
@scgkiran scgkiran deleted the dec_min_scale branch February 7, 2025 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants