feat: get scalar function invocation object from testcase #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
==========================================
+ Coverage 62.01% 62.19% +0.17%
==========================================
Files 44 44
Lines 9844 9898 +54
==========================================
+ Hits 6105 6156 +51
- Misses 3462 3464 +2
- Partials 277 278 +1 ☔ View full report in Codecov by Sentry. |
testcases/parser/nodes.go
Outdated
| } | ||
|
|
||
| func (tc *TestCase) signatureKey() string { | ||
| if tc.FuncType == ScalarFuncType { |
There was a problem hiding this comment.
Consider using a switch statement here so that when support for window is added it is handled instead of returning aggregate.
testcases/parser/nodes.go
Outdated
|
|
||
| func (tc *TestCase) ID() extensions.ID { | ||
| baseURI := tc.BaseURI | ||
| if !strings.HasPrefix(baseURI, "https") || !strings.HasPrefix(baseURI, "http") { |
There was a problem hiding this comment.
This check is being used to check that the URI is not a slash-prefixed file. So it could check for the prefix being a leading slash. Otherwise a check for a leading slash could be useful before appending it onto the Substrait default address.
EpsilonPrime
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.