Skip to content

Commit

Permalink
fix: add missing RelCommon field to WriteRel and DdlRel (#591)
Browse files Browse the repository at this point in the history
Adding the RelCommon field to WriteRel and DdlRel message types so that
they can be handled with the same common functionality as other
operators.

Addition of a new field is not a breaking change.

Context from [Slack
discussion](https://substrait.slack.com/archives/C02D7CTQXHD/p1705839323529739)
  • Loading branch information
joellubi authored Jan 23, 2024
1 parent 3251b1f commit d55703a
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions proto/substrait/algebra.proto
Original file line number Diff line number Diff line change
Expand Up @@ -487,6 +487,7 @@ message DdlRel {

// The body of the CREATE VIEW
Rel view_definition = 7;
RelCommon common = 8;

enum DdlObject {
DDL_OBJECT_UNSPECIFIED = 0;
Expand Down Expand Up @@ -535,6 +536,7 @@ message WriteRel {

// Output mode determines what is the output of executing this rel
OutputMode output = 6;
RelCommon common = 7;

enum WriteOp {
WRITE_OP_UNSPECIFIED = 0;
Expand Down

0 comments on commit d55703a

Please sign in to comment.