Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: faq section + post-join filter question #578

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

vbarua
Copy link
Member

@vbarua vbarua commented Nov 17, 2023

No description provided.

Copy link
Contributor

@jacques-n jacques-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it but I also think we need to avoid adding more top-level stuff. We already have too many. Is there way we can have either drop-down navs or left hand navs with this theme? I can't remember but I think there is.

@EpsilonPrime
Copy link
Member

I agree that we have too many top level items (11). I was looking to spend more time on the website but I already have 4 pending documentation updates. I'd lean towards getting this in and fixing the navigation later.

Copy link
Contributor

@jacques-n jacques-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this going in but we should also work on cleaning things up at the nav level.

@westonpace westonpace merged commit 7629e0e into main Dec 5, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants