Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add decimal type support for sum0 function #610

Merged
merged 1 commit into from
Mar 20, 2024
Merged

feat: add decimal type support for sum0 function #610

merged 1 commit into from
Mar 20, 2024

Conversation

liuyuhanalex
Copy link
Contributor

This PR adds support for decimal types in the sum0 function.
This is currently supported in Calcite.

@CLAassistant
Copy link

CLAassistant commented Mar 19, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

EpsilonPrime
EpsilonPrime reviewed Mar 19, 2024
View reviewed changes
Copy link
Member

@EpsilonPrime EpsilonPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! This version of sum0 does indeed appear to be missing.

extensions/functions_arithmetic_decimal.yaml Outdated Show resolved Hide resolved
vbarua
vbarua approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@vbarua vbarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look reasonable and are consistent with the behaviour of sum

@EpsilonPrime EpsilonPrime merged commit 6bd0c7b into substrait-io:main Mar 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiedeyantu xiedeyantu xiedeyantu left review comments

@vbarua vbarua vbarua approved these changes

@EpsilonPrime EpsilonPrime EpsilonPrime approved these changes

@jacques-n jacques-n Awaiting requested review from jacques-n jacques-n is a code owner

@cpcloud cpcloud Awaiting requested review from cpcloud cpcloud is a code owner

@westonpace westonpace Awaiting requested review from westonpace westonpace is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liuyuhanalex @CLAassistant @EpsilonPrime @vbarua @xiedeyantu