Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prevent proof transaction front run #421

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

fakedev9999
Copy link
Member

@fakedev9999 fakedev9999 commented Mar 5, 2025

The prove function is publicly callable. Anyone could front run a proof transaction by copying the proofBytes. Handles front run issueby committing prover address for aggregation proof.

ZKFP test tx.

Validity test tx.

@fakedev9999 fakedev9999 requested a review from ratankaliani March 5, 2025 00:24
@fakedev9999 fakedev9999 force-pushed the taehoon/handle-front-run branch 3 times, most recently from 3062e0e to 4994561 Compare March 5, 2025 23:03
Base automatically changed from taehoon/update-fdg to main March 6, 2025 19:01
@fakedev9999 fakedev9999 force-pushed the taehoon/handle-front-run branch 2 times, most recently from 18427da to 4f1d9c0 Compare March 6, 2025 19:13
Copy link
Member

@ratankaliani ratankaliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should name l1_address to be more clear. You should also update the docs to reflect that users need to commit to the address that they're using to generate the proof to prevent front-running.

@fakedev9999 fakedev9999 force-pushed the taehoon/handle-front-run branch 2 times, most recently from 830a0f6 to 71d1bfc Compare March 11, 2025 01:00
@fakedev9999 fakedev9999 force-pushed the taehoon/handle-front-run branch from 71d1bfc to 2a49953 Compare March 11, 2025 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants