Autofix #594
Merged
Autofix #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'cn' utility previously imported from a relative path is now imported from an absolute path, streamlining the overall import structure. This change promotes better readability and maintainability in 'placeholder.tsx'. Signed-off-by: Giovanni Ravalico <[email protected]>
The "cn" utility function's import statement has been updated to the latest path in the SuddenlyGiovanni component. This was done to ensure consistency across the project and enhance code readability. Signed-off-by: Giovanni Ravalico <[email protected]>
The accordion component code has undergone significant refactoring for better readability and maintenance. The changes involve inline boolean attributes simplification, such as changing 'disabled={true}' to 'disabled'. Another key change is updating of 'button' elements to include a 'type' attribute. ESLint warnings have also been disabled with a comment explaining the reasoning for the same. Moreover, the 'Array' object creation has been revised to include a type for better type safety.
Signed-off-by: Giovanni Ravalico <[email protected]>
The JSDoc in the use-toggle hook has been updated for better readability. The type indications of parameters have been removed. This makes the documentation more compact, and the type inference is handled by Typescript. Signed-off-by: Giovanni Ravalico <[email protected]>
The import statement for Typography component is updated for clarity. Also, 'true' was removed from disabled and asChild props in Button component for brevity, as it's understood in Javascript that without a provided value the prop is regarded as true. Signed-off-by: Giovanni Ravalico <[email protected]>
Remove unnecessary explicit 'true' values in various places in the collapsible component. This change makes the code cleaner and more readable, as 'true' is the default value for boolean props in React components. Signed-off-by: Giovanni Ravalico <[email protected]>
This commit simplifies the syntax for boolean props in the DropdownMenu component of the UI package. Instead of explicitly setting `asChild` and `disabled` props to `true`, they are now being used directly which is a cleaner, more efficient syntax in React. Signed-off-by: Giovanni Ravalico <[email protected]>
This change modifies the layout component to use the nullish coalescing operator for assigning the 'as' prop to 'body'. The update increases code clarity by explicitly handling null or undefined cases instead of relying on the previous falsy values check. Signed-off-by: Giovanni Ravalico <[email protected]>
Refactored mode-toggle.stories.tsx to import 'ReactElement' from 'react' and specify the return type of the 'Default' function. This change helps maintain a more robust and clearer code type specification. Signed-off-by: Giovanni Ravalico <[email protected]>
Updated the ModeToggle component to correctly utilize the 'asChild' prop in DropdownMenuTrigger. Instead of explicitly setting it to true, it's now being used as a standalone prop according to best practices. Signed-off-by: Giovanni Ravalico <[email protected]>
The requested changes adjusted the navigation menu story components, primarily importing elements from different locations and adjusting icon usage. The refactor includes changes in import paths, functional return type, and icon logo replaced with globe. Furthermore, asChild property in NavigationMenuLink was corrected from a boolean value to just stating "asChild". Signed-off-by: Giovanni Ravalico <[email protected]>
Added two eslint-disable comments in the skeleton.stories.tsx and blockquote.stories.tsx Storybook files. The disable rules were added for 'react/function-component-definition' and 'react/no-unescaped-entities' due to specific needs of Storybook stories. Also, a correction has been made on decorators type naming in blockquote stories. Signed-off-by: Giovanni Ravalico <[email protected]>
The Prose component has been updated to match the eslint styling guide and improve code readability. ReactElement has been added as a return type for the function, ensuring enhanced type safety. The import path for 'cn' has also been adjusted for better consistency. Signed-off-by: Giovanni Ravalico <[email protected]>
This commit ensures correct usage of React typescript in the table component of the typography storybook. It involves disabling a certain eslint rule for unescaped entities and explicitly defining the returning type of Table function as a ReactElement. Signed-off-by: Giovanni Ravalico <[email protected]>
An eslint-disable comment has been added to the "typography.stories.tsx" file in the ui package. This was necessary due to a Storybook story that was causing eslint to throw unescaped entities errors. Signed-off-by: Giovanni Ravalico <[email protected]>
The import path for the 'cn' utility function has been simplified. The path has been updated from '../lib/utils.ts' to '~/lib', enhancing the readability of the code and ensuring consistency in import statements. Signed-off-by: Giovanni Ravalico <[email protected]>
A comment has been added to disable the eslint rule "react/no-unescaped-entities" specifically for the motivations route file. The rule was disabled due to the requirements of a storybook story. Signed-off-by: Giovanni Ravalico <[email protected]>
A linting rule has been temporarily disabled and the placement of several lines of text has been adjusted within the content of the web application's index route. The improvements slightly enhance legibility without changing the overall structure or context of the content. Signed-off-by: Giovanni Ravalico <[email protected]>
The import statements in 'layout.tsx' have been restructured. Instead of separately importing 'PolymorphicComponentPropWithRef', 'PolymorphicRef', and 'cn', these are now imported from '~/lib' in a single statement for cleaner code. Signed-off-by: Giovanni Ravalico <[email protected]>
The loader function in the root.tsx file of the web app has been updated to import and use the Theme type from 'remix-themes'. This ensures correct typing and consistent theme implementation. The returned Promise now clearly specifies that the "theme" could be of type "Theme" or "null". Signed-off-by: Giovanni Ravalico <[email protected]>
The commit changes the type of props from 'any' to 'unknown' for the MDXComponent declaration in the env.d.ts file. Similarly, the frontmatter export type is also refactored from 'any' to 'unknown'. This provides more type safety and is less prone to potential runtime errors. Signed-off-by: Giovanni Ravalico <[email protected]>
The styling of an example email comment inside the 'Basics' interface has been updated. The email address is now wrapped in back-ticks to improve readability and standardize comment formatting. Signed-off-by: Giovanni Ravalico <[email protected]>
For the working module, mapper.ts under the resume route, the eslint rule for 'no-explicit-any' is temporarily disabled. This change is due to needing quick fixes in a 'Work In Progress' module where the rules might be causing interruptions. The plan is to eventually adhere to the standard and reactivate the rule. Signed-off-by: Giovanni Ravalico <[email protected]>
The diff changes involve adjustments to text wrapping on several lines in the _index.tsx file. To maintain a consistent style and adhere to column width constraints, line breaks were added where necessary, ensuring no substantive changes to the text content. Signed-off-by: Giovanni Ravalico <[email protected]>
Changed the type annotation of the App function in root.tsx from JSX.Element to ReactElement. This improves type safety and follows better the React Typing conventions. Signed-off-by: Giovanni Ravalico <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.