Ci cd/pull #603
Merged
Ci cd/pull #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The checks workflow has been updated to install dependencies without production dependencies, and to use Biome for code linting. The existing format checks using Prettier have been commented out, to be reintroduced in the future if required. Signed-off-by: Giovanni Ravalico <[email protected]>
A console.log was added to the Button component for debugging purposes. Additionally, the "useIgnoreFile" property was set to true in the biome .json file to ensure specific files and directories are ignored, avoiding unnecessary tracking or processing. Signed-off-by: Giovanni Ravalico <[email protected]>
The linting command in the push checks workflow was updated to prevent checking only changed files, now all files will be checked. Furthermore, an unnecessary console log was removed from the button component in the UI package. Signed-off-by: Giovanni Ravalico <[email protected]>
The linting command in the push-checks-workflow has been updated to format only changed files. In addition, an exception to the naming convention has been applied in the button component to accommodate a valid use case for the "asChild" prop. Signed-off-by: Giovanni Ravalico <[email protected]>
The GitHub workflow has been updated to change the code formatting process. Instead of linting the code, the workflow action now formats the code using Biome. Additionally, redundant code formatting steps with Prettier have been removed for clean up. Signed-off-by: Giovanni Ravalico <[email protected]>
The fetch-depth attribute has been added to the "checkout code" step in .github/workflows/push-checks-workflow.yml. This change is made to ensure that the entire history is fetched during the checkout process for accurate comparison and test results. Signed-off-by: Giovanni Ravalico <[email protected]>
The ESLint linting command in `.github/workflows/push-checks-workflow.yml` has been updated to only lint changed files. This change will improve the efficiency of the linting process by targeting only the updated files instead of the entire codebase. Signed-off-by: Giovanni Ravalico <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| - name: 📝 Format code (with Prettier) | ||
| run: pnpm format | ||
| - name: 🚨 Lint code (with ESLint) | ||
| run: | |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2046:warning:1:38: Quote this to prevent word splitting [shellcheck]
| - name: 📝 Format code (with Prettier) | ||
| run: pnpm format | ||
| - name: 🚨 Lint code (with ESLint) | ||
| run: | |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:2:20: Double quote to prevent globbing and word splitting [shellcheck]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.