Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slowed clock to 80Mhz #54

Merged
merged 1 commit into from
Feb 21, 2020
Merged

slowed clock to 80Mhz #54

merged 1 commit into from
Feb 21, 2020

Conversation

samuk
Copy link
Collaborator

@samuk samuk commented Feb 8, 2020

slowed clock to 80Mhz

slowed clock to 80Mhz
@samuk
Copy link
Collaborator Author

samuk commented Feb 9, 2020

Tested with BLE and WiFi versions.

Page load is a little slow on WiFi but it still works.

@samuk samuk requested a review from paidforby February 9, 2020 18:26
@paidforby
Copy link
Contributor

Thanks for the contribution! Sorry about not reviewing sooner, I've been busy the last week and most of my disaster-radio energy has been dedicated to addressing the String/struct issue. This contribution makes sense to me. Though I'd rather keep the clock speed at the default (240Mhz I believe) and just have these line in there so people know there is the option. Eventually, we could add clock speed to the user preferences as something that could be set on reboot or maybe this could be part of a pre-compiled "low-power" binary that enables other features that sacrifice performance for energy usage.

I'm going to add clock speed as a define in config.h, then I'll merge this commit.

@@ -387,6 +387,9 @@ void setup()
{
Serial.begin(115200);
delay(200);

setCpuFrequencyMhz(80); //Set CPU clock to 80MHz fo example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change to setCpuFrequencyMhz(CLOCK_SPEED) and then in config.h add
#define CLOCK_SPEED 240

@samuk samuk mentioned this pull request Feb 12, 2020
@paidforby paidforby merged commit ec13738 into sudomesh:master Feb 21, 2020
@paidforby
Copy link
Contributor

Made the changes I suggested, you can set the clock speed in config.h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants