Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SkipTable patterns parameter #161

Merged
merged 3 commits into from
Oct 14, 2021
Merged

Add SkipTable patterns parameter #161

merged 3 commits into from
Oct 14, 2021

Conversation

nminhquan
Copy link
Contributor

Hi, as my application may arbitrarily created some tables which doesn't relate to Business table, this is good if we could add a parameter to skip those table out of the generated diagrams.
Please take a look and give me your idea.
Thanks

Copy link
Owner

@sue445 sue445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nminhquan Thanks for the great patch!

But make integration_test is failed.
https://github.com/sue445/plant_erd/pull/161/checks?check_run_id=3890917142

Update help command in README.md

lib/erd_generator.go Outdated Show resolved Hide resolved
lib/erd_generator_test.go Outdated Show resolved Hide resolved
@nminhquan
Copy link
Contributor Author

Hi @sue445 I have updated the README.md, the test result is passed on sqlite3, mysql and postgresql
`Running tool: /usr/local/go/bin/go test -timeout 30s -run ^TestReadme$ github.com/sue445/plant_erd/_integration -v

=== RUN TestReadme
=== RUN TestReadme/sqlite3
=== RUN TestReadme/mysql
=== RUN TestReadme/postgresql
--- PASS: TestReadme (0.43s)
--- PASS: TestReadme/sqlite3 (0.40s)
--- PASS: TestReadme/mysql (0.01s)
--- PASS: TestReadme/postgresql (0.01s)
PASS
ok github.com/sue445/plant_erd/_integration 0.666s
`

@sue445 sue445 self-requested a review October 14, 2021 12:14
Copy link
Owner

@sue445 sue445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sue445 sue445 merged commit 89e26db into sue445:master Oct 14, 2021
@sue445
Copy link
Owner

sue445 commented Oct 14, 2021

@nminhquan I released as v0.3.0 🚀

sue445 added a commit that referenced this pull request Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants