Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for oracle open cursor and foreign key issue #225

Merged
merged 8 commits into from
Aug 15, 2023

Conversation

javedashraf
Copy link
Contributor

  • Added stmt.Close for prepared statements to adapter.go resolve open cursor in oracle
  • Updated foreign key compare for ToMermaid and ToERD functions to use lower case compare as it does not work for oracle

@sue445 sue445 self-requested a review August 3, 2023 15:10
adapter/oracle/adapter.go Outdated Show resolved Hide resolved
adapter/oracle/adapter.go Outdated Show resolved Hide resolved
adapter/oracle/adapter.go Outdated Show resolved Hide resolved
adapter/oracle/adapter.go Outdated Show resolved Hide resolved
adapter/oracle/adapter.go Outdated Show resolved Hide resolved
db/schema.go Show resolved Hide resolved
@sue445 sue445 self-requested a review August 15, 2023 00:53
Copy link
Owner

@sue445 sue445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@sue445 sue445 merged commit cfb10e8 into sue445:master Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants