report these warnings

sueliitj · May 21, 2018 · 3540ed7 · 3540ed7
1 parent 2578dc6
commit 3540ed7
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 2 deletions.
diff --git a/script/changelog/parser.ts b/script/changelog/parser.ts
@@ -101,6 +101,7 @@ export function getChangelogEntriesSince(previousVersion: string): string[] {
   const root = Path.dirname(Path.dirname(__dirname))
   const changelogPath = Path.join(root, 'changelog.json')
 
+  // eslint-disable-next-line no-sync
   const buffer = Fs.readFileSync(changelogPath)
   const changelogText = buffer.toString()
 

diff --git a/script/dist-info.ts b/script/dist-info.ts
@@ -88,9 +88,11 @@ export function getWindowsIdentifierName() {
 }
 
 export function getBundleSizes() {
+  // eslint-disable-next-line no-sync
   const rendererStats = Fs.statSync(
     Path.join(projectRoot, 'out', 'renderer.js')
   )
+  // eslint-disable-next-line no-sync
   const mainStats = Fs.statSync(Path.join(projectRoot, 'out', 'main.js'))
   return { rendererSize: rendererStats.size, mainSize: mainStats.size }
 }

diff --git a/script/publish.ts b/script/publish.ts
@@ -154,6 +154,7 @@ function upload(assetName: string, assetPath: string) {
         if (error) {
           reject(error)
         } else {
+          // eslint-disable-next-line no-sync
           const stats = Fs.statSync(assetPath)
           const hash = Crypto.createHash('sha1')
           hash.setEncoding('hex')

diff --git a/script/run.ts b/script/run.ts
@@ -1,6 +1,6 @@
 import { join } from 'path'
 import { spawn, SpawnOptions } from 'child_process'
-import { statSync } from 'fs'
+import * as Fs from 'fs'
 import { getDistPath, getExecutableName } from './dist-info'
 
 const distPath = getDistPath()
@@ -26,7 +26,8 @@ if (process.platform === 'darwin') {
 
 export function run(spawnOptions: SpawnOptions) {
   try {
-    const stats = statSync(binaryPath)
+    // eslint-disable-next-line no-sync
+    const stats = Fs.statSync(binaryPath)
     if (!stats.isFile()) {
       return null
     }

diff --git a/script/validate-changelog.ts b/script/validate-changelog.ts
@@ -36,6 +36,7 @@ function formatErrors(errors: Ajv.ErrorObject[]): string {
 const repositoryRoot = Path.dirname(__dirname)
 const changelogPath = Path.join(repositoryRoot, 'changelog.json')
 
+// eslint-disable-next-line no-sync
 const changelog = Fs.readFileSync(changelogPath, 'utf8')
 
 let changelogObj = null