fix the compiler warnings

sueliitj · Jun 22, 2018 · 8110a3b · 8110a3b
1 parent bbab6f3
commit 8110a3b
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/script/build.ts b/script/build.ts
@@ -123,10 +123,18 @@ function packageApp(
     )
   }
 
+  const toPackageArch = (targetArch: string | undefined): packager.arch => {
+    if (targetArch === 'arm64' || targetArch === 'x64') {
+      return targetArch
+    }
+
+    return 'x64'
+  }
+
   const options: packager.Options & IPackageAdditionalOptions = {
     name: getExecutableName(),
     platform: toPackagePlatform(process.platform),
-    arch: process.env.TARGET_ARCH || 'x64',
+    arch: toPackageArch(process.env.TARGET_ARCH),
     asar: false, // TODO: Probably wanna enable this down the road.
     out: getDistRoot(),
     icon: path.join(projectRoot, 'app', 'static', 'logos', 'icon-logo'),

diff --git a/script/review-logs.ts b/script/review-logs.ts
@@ -8,7 +8,13 @@ import { getExecutableName } from './dist-info'
 
 function getUserDataPath() {
   if (process.platform === 'win32') {
-    return path.join(process.env.APPDATA, getExecutableName())
+    if (process.env.APPDATA) {
+      return path.join(process.env.APPDATA, getExecutableName())
+    } else {
+      throw new Error(
+        `Unable to find the application data directory on Windows :(`
+      )
+    }
   } else if (process.platform === 'darwin') {
     const home = os.homedir()
     return path.join(home, 'Library', 'Application Support', getProductName())