Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept both "Minor" and "Aeolian", "Major" and "Minor" #2237

Closed
pikurasa opened this issue May 4, 2020 · 1 comment · Fixed by #2276
Closed

Accept both "Minor" and "Aeolian", "Major" and "Minor" #2237

pikurasa opened this issue May 4, 2020 · 1 comment · Fixed by #2276

Comments

@pikurasa
Copy link
Collaborator

pikurasa commented May 4, 2020

I tried to use an input block for the mode/key value as in the following:

Screenshot at 2020-05-04 04:18:32 input name

I noticed that typing "minor" does not result in any change.

I see that on line 6843 of block.js the expected input is "aeolian", which works.

if (that.text.text === _("major") + " / " + _("ionian")) {
		    that.value = "major";
                } else if (
                    that.text.text ===
                    _("minor") + " / " + _("aeolian")
                ) {
                    that.value = "aeolian";

It would be nice if "minor" also worked.

It is also noteworthy that the greek name was chosen instead of "minor", but for "major" the greek name was not chosen. I assume that typing "Ionian" would not affect anything. It would be nice if that would also work.

Test file
Input-minor.html.zip

@pikurasa pikurasa added this to the GSOC2020 milestone May 8, 2020
@aviral243
Copy link
Member

@pikurasa The fix for this is simple. We just need to add an alias for minor in MUSICALMODES defined in musicutils.js.

ionian is present so that is not required.

I'll submit a patch.

belginkoc added a commit to belginkoc/musicblocks that referenced this issue Nov 30, 2023
An attempt for a quiz project for issue sugarlabs#2237
walterbender pushed a commit that referenced this issue May 14, 2024
* Add files via upload

An attempt for a quiz project for issue #2237

* Add files via upload

Completed CrossWord Puzzle for Issue #3327

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants