-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Performane] : Fix slow loading of Music Blocks on all the browsers #4331
base: master
Are you sure you want to change the base?
Conversation
@apsinghdev I would love to contribute to this PR can you suggest me some reference |
Thanks @omsuneri. I'll let you know if I need help. 🙂 |
@walterbender Thanks for letting me know. Don't know why it didn't appear on my browser. Anyways, next task is to optimise this video as it's blocking the other ops. It's causing |
10723b3
to
14518ba
Compare
Update: fixed the issue: #4331 (comment) Experimented running MB using We are using SimpleHTTPServer to run Music Blocks to the client. But, SimpleHTTPServer doesn't support advanced features like Keep-Alive. I have experimented with running MB using http-server and it has Keep-Alive by default. ![]() Also, I found http-server is comparatively fast increasing performance scores from 70 to 75 on the lighthouse. ![]() Getting some feedback on these ideas. Will push it soon! |
maybe https-server? |
14518ba
to
5084cf7
Compare
I've replaced |
@walterbender I've used a custom server using I tested it and it is showing really good performance. ![]() If you get a chance, please test 62397de |
Seems good to me. |
62397de
to
e6ad80f
Compare
Thanks! I'll do more testing. |
e6ad80f
to
901de5c
Compare
@walterbender, I've fixed most of the critical issues blocking MB's loading process. I've noticed two main issues that need to be worked on:
To tackle both of these issues we'd need to plan about it as these are big breaking changes that will impact the whole codebase. For now, I've made this PR ready and will work on this issue as we discuss further. Please have a look. |
@apsinghdev The video perfectly fills the screen now. However, the loading text is now missing. As for load time, I tested the master branch and 62397de with the default Sol, Mi, Sol code. Both took 13 seconds to load. |
@pikurasa Thanks for your feedback! I'll fix the missing loading text issue. Also, which tool have you used to calculate the load time? |
fixes: #4305
This PR fixes the slow loading of Music Blocks.
(Draft)
This PR will contain comparatively bigger changes. So I'll keep on adding commits here to describe what they do.
Current Stats
Total loading time -
~ 16.0 seconds
cc @walterbender @pikurasa
Changes
82bf4ca formats the index.html file as it was not formatted properly.
4ffa134 add header links in optimized order to efficient loading
10723b3 fixes the
render-blocking
issue and bring thecumulative-layout-shift
score from0.20
to0.07
5084cf7 implements
http-server
replacing theSimpleHTTPServer
. UpgradesHTTP
from1.0
to1.1
withKeep-Alive
enablede6ad80f reduces
Largest Contentful Paint element
from4,297 ms
to2,400 ms