frame key double press consistency #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the frame key is pressed rapidly, some presses are ignored, because the animation position is used to determine if the frame is visible. To fix, - remove class _KeyListener as it is not required, see also 3e28f56, - add a flag for whether the frame is wanted or not, self._wanted, - add a toggle() method, which calls show() or hide() according to last known wanted state, and call it from the mouse enter corner or frame key press methods, - do not test frame visibility in show() or hide(), depend on _wanted, - in the gesture handler, use toggle() instead of show() or hide(), Test case: xdotool key F6 key F6 key F6 should be equivalent in final effect to xdotool key F6 Fixes #4806 https://bugs.sugarlabs.org/ticket/4806
|
Another way to reproduce the issue: move your mouse in and out of the corners with about 0.5sec between each corner activation |
|
Great patch, it makes sugar feel much more responsive. I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the frame key is pressed rapidly, some presses are ignored, because the animation position is used to determine if the frame is visible.
To fix,
Test case:
should be equivalent in final effect to
Fixes #4806.