Skip to content

feat: atrium-repo

feat: atrium-repo #769

Triggered via pull request February 18, 2025 23:35
@DrChatDrChat
synchronize #272
DrChat:repo
Status Success
Total duration 1m 31s
Artifacts

rust.yml

on: pull_request
Matrix: Rust
Fit to window
Zoom out
Zoom in

Annotations

5 errors
Rust (1.75.0): atrium-repo/src/mst.rs#L796
[clippy] reported by reviewdog 🐶 error: this expression creates a reference which is immediately dereferenced by the compiler --> atrium-repo/src/mst.rs:796:63 | 796 | for entry in node.entries_with_prefix(&prefix).rev() { | ^^^^^^^ help: change this to: `prefix` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]` Raw Output: atrium-repo/src/mst.rs:796:63:e:error: this expression creates a reference which is immediately dereferenced by the compiler --> atrium-repo/src/mst.rs:796:63 | 796 | for entry in node.entries_with_prefix(&prefix).rev() { | ^^^^^^^ help: change this to: `prefix` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]` __END__
Rust (1.75.0): atrium-repo/src/mst.rs#L1071
[clippy] reported by reviewdog 🐶 error: `if` chain can be rewritten with `match` --> atrium-repo/src/mst.rs:1071:25 | 1071 | / if kp == prefix { 1072 | | list.push(NodeEntry::Leaf(t.clone())); 1073 | | continue; 1074 | | } else if prefix < kp { ... | 1078 | | break; 1079 | | } | |_________________________^ | = help: consider rewriting the `if` chain to use `cmp` and `match` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_chain = note: `-D clippy::comparison-chain` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::comparison_chain)]` Raw Output: atrium-repo/src/mst.rs:1071:25:e:error: `if` chain can be rewritten with `match` --> atrium-repo/src/mst.rs:1071:25 | 1071 | / if kp == prefix { 1072 | | list.push(NodeEntry::Leaf(t.clone())); 1073 | | continue; 1074 | | } else if prefix < kp { ... | 1078 | | break; 1079 | | } | |_________________________^ | = help: consider rewriting the `if` chain to use `cmp` and `match` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_chain = note: `-D clippy::comparison-chain` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::comparison_chain)]` __END__
Rust (1.75.0): atrium-repo/src/repo.rs#L418
[clippy] reported by reviewdog 🐶 error: the following explicit lifetimes could be elided: 'a --> atrium-repo/src/repo.rs:418:22 | 418 | pub async fn add<'a, C: Collection>( | ^^ 419 | &'a mut self, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `-D clippy::needless-lifetimes` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_lifetimes)]` Raw Output: atrium-repo/src/repo.rs:418:22:e:error: the following explicit lifetimes could be elided: 'a --> atrium-repo/src/repo.rs:418:22 | 418 | pub async fn add<'a, C: Collection>( | ^^ 419 | &'a mut self, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `-D clippy::needless-lifetimes` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_lifetimes)]` __END__
Rust (1.75.0): atrium-repo/src/repo.rs#L444
[clippy] reported by reviewdog 🐶 error: the following explicit lifetimes could be elided: 'a --> atrium-repo/src/repo.rs:444:25 | 444 | pub async fn update<'a, C: Collection>( | ^^ 445 | &'a mut self, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes Raw Output: atrium-repo/src/repo.rs:444:25:e:error: the following explicit lifetimes could be elided: 'a --> atrium-repo/src/repo.rs:444:25 | 444 | pub async fn update<'a, C: Collection>( | ^^ 445 | &'a mut self, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes __END__
Rust (1.75.0): atrium-repo/src/repo.rs#L470
[clippy] reported by reviewdog 🐶 error: the following explicit lifetimes could be elided: 'a --> atrium-repo/src/repo.rs:470:25 | 470 | pub async fn delete<'a, C: Collection>( | ^^ 471 | &'a mut self, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes Raw Output: atrium-repo/src/repo.rs:470:25:e:error: the following explicit lifetimes could be elided: 'a --> atrium-repo/src/repo.rs:470:25 | 470 | pub async fn delete<'a, C: Collection>( | ^^ 471 | &'a mut self, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes __END__