Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user and password are not percent-decoded #166

Open
prk3 opened this issue Feb 8, 2022 · 1 comment
Open

user and password are not percent-decoded #166

prk3 opened this issue Feb 8, 2022 · 1 comment

Comments

@prk3
Copy link
Contributor

prk3 commented Feb 8, 2022

Hi! It looks like clickhouse-rs does not percent-decode username and password strings extracted from DSNs.

fn get_password_from_url(url: &Url) -> Option<&str> {
url.password().map(|password| password)
}

Because of that, it's not possible to pass a password containing / or other symbols in DSN. Two other libraries that I checked, mysql-async and lapin, decode username and password strings. Example here:

https://github.com/blackbeam/mysql_async/blob/0778dea4c9a9f851ff41753e92208dcdf3824c40/src/opts.rs#L1003-L1014

@suharev7
Copy link
Owner

Hi! Thanks for this issue. This feature was pushed and will be available in the next release.

andrebsguedes pushed a commit to andrebsguedes/clickhouse-rs that referenced this issue Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants