Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reflect metadta peer dependency #463

Merged
merged 3 commits into from
Oct 18, 2024
Merged

fix: reflect metadta peer dependency #463

merged 3 commits into from
Oct 18, 2024

Conversation

qballer
Copy link
Collaborator

@qballer qballer commented Oct 11, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

I've update peer dependencies where needed.
I've also sorted the root package.json like the linter suggested.

  • Bugfix

Issue Number: #461

Does this PR introduce a breaking change?

  • No

@qballer qballer requested a review from omermorad October 11, 2024 14:17
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (next@4e3e6ba). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #463   +/-   ##
=======================================
  Coverage        ?   93.30%           
=======================================
  Files           ?       25           
  Lines           ?      568           
  Branches        ?       94           
=======================================
  Hits            ?      530           
  Misses          ?       30           
  Partials        ?        8           
Flag Coverage Δ
core.unit 95.67% <ø> (?)
di.inversify 93.68% <ø> (?)
di.nestjs 87.25% <ø> (?)
doubles.jest 100.00% <ø> (?)
doubles.sinon 100.00% <ø> (?)
doubles.vitest 100.00% <ø> (?)
unit 77.27% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qballer qballer force-pushed the peer_reflect_metadata branch from fee8e5e to dc6a3d4 Compare October 11, 2024 14:22
@qballer qballer force-pushed the peer_reflect_metadata branch from e914361 to 336621d Compare October 11, 2024 14:29
packages/di/inversify/package.json Outdated Show resolved Hide resolved
packages/di/nestjs/package.json Outdated Show resolved Hide resolved
@qballer qballer requested a review from omermorad October 13, 2024 19:56
@qballer qballer force-pushed the peer_reflect_metadata branch 2 times, most recently from bc7d812 to 5bd3118 Compare October 18, 2024 08:13
@qballer qballer force-pushed the peer_reflect_metadata branch from 5bd3118 to 470599b Compare October 18, 2024 08:16
@omermorad omermorad changed the base branch from master to next October 18, 2024 11:01
@omermorad omermorad merged commit 164ff93 into next Oct 18, 2024
22 checks passed
@omermorad omermorad deleted the peer_reflect_metadata branch October 18, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants