Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade ruby ci to 3.4 #4534

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

upgrade ruby ci to 3.4 #4534

wants to merge 1 commit into from

Conversation

dnoneill
Copy link
Contributor

@dnoneill dnoneill commented Jan 10, 2025 •
edited
Loading

jcoyne
jcoyne requested changes Jan 10, 2025
View reviewed changes
.github/workflows/ruby.yml
@@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby: ['3.2', '3.3']
ruby: ['3.3', '3.4']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SW is currently deployed on 3.2. So we should keep that until we've update the deploy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to have to wait until that webmock issue is fixed anyway. I will convert this to draft

@dnoneill dnoneill marked this pull request as draft January 10, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcoyne jcoyne jcoyne requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnoneill @jcoyne