Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active facet pills - spacing and hover #60

Closed
dbranchini opened this issue Dec 3, 2024 · 1 comment · Fixed by #84
Closed

Active facet pills - spacing and hover #60

dbranchini opened this issue Dec 3, 2024 · 1 comment · Fixed by #84
Assignees
Labels

Comments

@dbranchini
Copy link

dbranchini commented Dec 3, 2024

The left side of the pill should not change when hovering the value. The right side close icon (depicted as an X) should change to red when hovering (and that's working correctly). See the issue below:

Also, please add some padding to the left side of the pill. It's designed to be 12px as seen below:

Screenshot 2024-12-03 at 1 08 30 PM

https://www.figma.com/design/K1syTsalaB1nlRftgOi0Pw/DLSS-Components?node-id=115-302&t=UfEvQvUFy6o1PXPt-4

@jcoyne
Copy link
Contributor

jcoyne commented Dec 13, 2024

Hover style is tracking an issue in Blacklight: projectblacklight/blacklight#3469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants