Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin faraday >= 2 #970

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Pin faraday >= 2 #970

merged 1 commit into from
Apr 10, 2023

Conversation

thatbudakguy
Copy link
Member

@thatbudakguy thatbudakguy commented Apr 7, 2023

This removes the downstream dependency on patron, which needs
cURL headers in order to build correctly on Ubuntu machines.

The missing headers cause issues on both GitHub CI runners (actions/runner-images#37)
and our automated deploys
(https://sul-ci-prod.stanford.edu/job/SUL-DLSS/job/earthworks/job/master/56/display/redirect).

@thatbudakguy thatbudakguy changed the title update faraday Pin faraday >= 2 Apr 7, 2023
@thatbudakguy
Copy link
Member Author

thatbudakguy commented Apr 7, 2023

blocked on #969 which includes faraday 2 compatibility; will rebase when that is merged rebased

@thatbudakguy thatbudakguy marked this pull request as ready for review April 8, 2023 16:33
@cbeer
Copy link
Member

cbeer commented Apr 10, 2023

I think code like:

faraday.basic_auth(ENV.fetch('GEOSERVER_USER', nil), ENV.fetch('GEOSERVER_PASS', nil))

isn't 2.x compatible, is it (also used in other scripts files)?

@thatbudakguy
Copy link
Member Author

Hmm, I didn't know about any of those files in scripts. From a cursory glance, it seems like they are similar to tasks that @kimdurante does manually right now (like updating GeoWebCache for a layer). The OGP related stuff we no longer need, since we're not committing to maintain that old data anymore (per discussion with GIS team).

I could see about making them faraday 2.x compatible if it's just a matter of changing those basic_auth calls. Do you know anything else about these scripts?

@thatbudakguy
Copy link
Member Author

ok, I was able to just change basic_auth to set_basic_auth in the 4 scripts that use it, and confirm that at least one of the scripts executed fine this way. maybe that's good enough?

This removes the downstream dependency on patron, which needs
cURL headers in order to build correctly on Ubuntu machines.

The missing headers cause issues on both GitHub CI runners (actions/runner-images#37)
and our automated deploys
(https://sul-ci-prod.stanford.edu/job/SUL-DLSS/job/earthworks/job/master/56/display/redirect).
@thatbudakguy thatbudakguy requested a review from cbeer April 10, 2023 19:24
@cbeer cbeer merged commit 8c710ca into master Apr 10, 2023
@cbeer cbeer deleted the update-faraday branch April 10, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants