Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Blacklight 8. #2615

Merged
merged 35 commits into from
Nov 12, 2024
Merged

Update to Blacklight 8. #2615

merged 35 commits into from
Nov 12, 2024

Conversation

cbeer
Copy link
Member

@cbeer cbeer commented Oct 24, 2024

TODO:

Screenshot 2024-11-04 at 5 21 07 PM
  • undefined local variable or method view_config for CustomViewerComponent when visiting show page for uploaded item
Screenshot 2024-11-04 at 5 06 55 PM
  • alert modal close x icon missing
  • Hide IIIF icon in gallery and masonry view
  • move metadata even more the left with a smaller margin in the list results view
  • adjust browse category lists view so there isn't so much margin
  • in the masonry view the text displayed on hover looks bad

@cbeer cbeer force-pushed the bl8 branch 7 times, most recently from 70f295c to e45120c Compare October 25, 2024 22:44
@corylown corylown mentioned this pull request Oct 30, 2024
@corylown corylown force-pushed the bl8 branch 4 times, most recently from 8be7743 to 6acf311 Compare November 6, 2024 16:48
@corylown corylown marked this pull request as ready for review November 7, 2024 14:16
@corylown corylown force-pushed the bl8 branch 2 times, most recently from 4332cd0 to 0100de9 Compare November 7, 2024 19:00
@taylor-steve
Copy link
Contributor

Here are two things I noticed. Not sure if they are a part of this work or not.

  1. /search?group=true&q=Senatorio&search_field=default&view=gallery with "Group by exhibit" selected.
  • 'Group by exhibit' isn't visually selected
  • Missing exhibit count?

prod:
Screenshot 2024-11-08 at 2 01 09 PM

stage:
Screenshot 2024-11-08 at 2 01 00 PM

  1. Same /search?q=Senatorio&search_field=default search but with "All results" selected. Should the IIIF icon be down below to the right like the other search results?

Screenshot 2024-11-08 at 2 32 43 PM

Great work. Happy to approve if these issues aren't relevant.

@taylor-steve taylor-steve merged commit 59a7dd4 into main Nov 12, 2024
2 checks passed
@taylor-steve taylor-steve deleted the bl8 branch November 12, 2024 19:52
@corylown corylown restored the bl8 branch November 22, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants