allow the user to skip notifying email #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peetucket
force-pushed
the
allow-skip-notify
branch
from
4525d6b to
2dac122
Compare
mjgiarlo
reviewed
Oct 10, 2023
| @@ -10,10 +10,11 @@ class Endpoint # rubocop:disable Metrics/ClassLength | |||
| # @param client [GlobusClient] a configured instance of the GlobusClient | |||
| # @param path [String] the path to operate on | |||
| # @param user_id [String] a Globus user ID (e.g., a @stanford.edu email address) | |||
| def initialize(client, path:, user_id:) | |||
| def initialize(client, path:, user_id:, notify_email: true) | |||
There was a problem hiding this comment.
Can you add a new @param YARD doc above?
mjgiarlo
approved these changes
Oct 10, 2023
mjgiarlo
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this change made? 🤔
Allow consumers of the client to ask Globus to skip sending emails. Defaults to "true" so will send email unless you opt out when initializing the client.
How was this change tested? 🤨
New spec