Update sdr client #3083
Merged
Update sdr client #3083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peetucket
commented
Jun 9, 2023
| # ActiveStorage is expecting "application/x-stata-dta" not "application/x-stata-dta;version=14" | ||
| content_type&.split(';')&.first | ||
| end | ||
|
|
There was a problem hiding this comment.
this logic is now handled in the new version of sdr-client, so we don't need it here anymore
There was a problem hiding this comment.
nice! ok, yeah, i like moving this into sdr-client, despite my wishy-washy feedback on the sdr-client PR. hadn't looked at this yet, so wasn't sure whether there'd be redundant processing (which i was more worried about for intelligibility than for performance reasons).
This was referenced Jun 9, 2023
peetucket
force-pushed
the
update-sdr-client
branch
from
f11629f to
41cd256
Compare
edsu
approved these changes
Jun 15, 2023
jmartin-sul
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
approving, but holding off on merge till sul-dlss/sdr-api#585 is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this change made? 🤔
Use latest sdr-client gem to handle invalid JSON files
Fixes #3075
[HOLD] until sul-dlss/sdr-client#284 is merged and a new release is cut, then come back here and update the gem file to use the correct version, re bundle install and update this PR.Also requires sul-dlss/sdr-api#585
How was this change tested? 🤨
on QA